-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python patcher compatibility #100
Conversation
Supports the buttons that are identified with `XButton1` and `XButton2`
section/Init.cpp
Outdated
@@ -0,0 +1,10 @@ | |||
#include "moho.h" | |||
|
|||
extern const uintptr_t FIRST_CTOR; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the behavior of this documented? As in, what does this new file do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file calls global variables constructors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be interesting to have some form of documentation of how certain procedures work that are used often. For example: registering a new sim or UI function.
I of course can not read and understand the code exactly. But in general these changes are related to fixing paths and/or types. There appear to be just a few large convention changes, such as the Init.cpp
file.
TBH I'd leave it for another PR (this one #102 for example) |
Includes changes for python patcher to work: