Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python patcher compatibility #100

Merged
merged 14 commits into from
Nov 12, 2024
Merged

Conversation

4z0t
Copy link
Member

@4z0t 4z0t commented Nov 11, 2024

Includes changes for python patcher to work:

  • relative includes
  • old ways to register lua function
  • proper type conversions
  • removed LuaJIT DLL load

section/Init.cpp Outdated
@@ -0,0 +1,10 @@
#include "moho.h"

extern const uintptr_t FIRST_CTOR;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the behavior of this documented? As in, what does this new file do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file calls global variables constructors.

section/LuaExts.cpp Outdated Show resolved Hide resolved
hooks/LuaFuncRegs.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Garanas Garanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be interesting to have some form of documentation of how certain procedures work that are used often. For example: registering a new sim or UI function.

I of course can not read and understand the code exactly. But in general these changes are related to fixing paths and/or types. There appear to be just a few large convention changes, such as the Init.cpp file.

@4z0t
Copy link
Member Author

4z0t commented Nov 12, 2024

It would be interesting to have some form of documentation of how certain procedures work that are used often. For example: registering a new sim or UI function.

I of course can not read and understand the code exactly. But in general these changes are related to fixing paths and/or types. There appear to be just a few large convention changes, such as the Init.cpp file.

TBH I'd leave it for another PR (this one #102 for example)

@Garanas Garanas merged commit 64368d9 into FAForever:master Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants